autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

glitch in General.pm that causes "make check" to fail on Solaris 8


From: Paul Eggert
Subject: glitch in General.pm that causes "make check" to fail on Solaris 8
Date: Thu, 12 Aug 2004 10:27:26 -0700
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

I installed this.  Odd that it's never been caught before.  I found
the problem when testing on a Sun-only (no GNU code other than GNU m4
1.4.1) Solaris 8 sparc.

2004-08-12  Paul Eggert  <address@hidden>

        * lib/Autom4te/General.pm (END): Return correct exit status even
        if unlink succeeds and sets $?.  Needed with Solaris 8's perl 5.00503.

--- lib/Autom4te/General.pm     21 Aug 2003 17:50:11 -0000      1.32
+++ lib/Autom4te/General.pm     12 Aug 2004 17:24:16 -0000      1.33
@@ -1,5 +1,5 @@
 # autoconf -- create `configure' using m4 macros
-# Copyright (C) 2001, 2002, 2003  Free Software Foundation, Inc.
+# Copyright (C) 2001, 2002, 2003, 2004 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -183,7 +183,8 @@ sub END
   #        this sets $? = 255
   #
   # Cases 1), 2), and 3b) are fine, but we prefer $? = 1 for 3a) and 3c).
-  $? = 1 if ($! && $! == $?) || $? == 255;
+  my $status = $?;
+  $status = 1 if ($! && $! == $?) || $? == 255;
   # (Note that we cannot safely distinguish calls to `exit (n)'
   # from calls to die when `$! = n'.  It's not big deal because
   # we only call `exit (0)' or `exit (1)'.)
@@ -215,6 +216,8 @@ sub END
       $? = 1;
       return;
     }
+
+  $? = $status;
 }
 
 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]