autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: 50-gary-work-around-cvs-autoreconf-aclocal-m4t-bug.patch


From: Gary V. Vaughan
Subject: Re: FYI: 50-gary-work-around-cvs-autoreconf-aclocal-m4t-bug.patch
Date: Fri, 05 Sep 2003 12:25:17 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030903 Thunderbird/0.2

I wrote:

As best as I can tell, autoreconf calls aclocal to generate aclocal.m4t, and then at line 252 calls update_file, which in turn doesn't delete aclocal.m4t if it decides the update is not needed. I can't find the definition of update_file to check (I didn't look very hard) why that happens...

Looked a bit harder... this patch works for me.  Okay to commit?

Cheers,
        Gary.
--
  ())_.  Gary V. Vaughan    gary@(oranda.demon.co.uk|gnu.org)
  ( '/   Research Scientist http://www.oranda.demon.co.uk       ,_())____
  / )=   GNU Hacker         http://www.gnu.org/software/libtool  \'      `&
`(_~)_   Tech' Author       http://sources.redhat.com/autobook   =`---d__/
Index: ChangeLog
from  Gary V. Vaughan  <address@hidden>

        * lib/Autom4te/FileUtils.pm (update_file): Remove the source before
        returning if there was no difference between source and destination.

Index: lib/Autom4te/FileUtils.pm
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/Autom4te/FileUtils.pm,v
retrieving revision 1.3
diff -u -p -u -r1.3 FileUtils.pm
--- lib/Autom4te/FileUtils.pm 21 Aug 2003 16:15:40 -0000 1.3
+++ lib/Autom4te/FileUtils.pm 5 Sep 2003 11:16:01 -0000
@@ -153,6 +153,7 @@ sub update_file ($$)
     {
       # File didn't change, so don't update its mod time.
       msg 'note', "`$to' is unchanged";
+      unlink ($from) || fatal "cannot not remove $from: $!";
       return
     }
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]