[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
FYI: functions.m4: restore mistakenly removed spaces in sed LHS
From: |
Jim Meyering |
Subject: |
FYI: functions.m4: restore mistakenly removed spaces in sed LHS |
Date: |
Thu, 22 May 2003 10:38:40 +0200 |
Hi!
Removing a string of SPC bytes before a TAB is usually just fine.
I suspect that it is always ok when only indentation is affected,
but in character ranges, regular expressions, sed expressions, etc.
it's *not* ok to convert ` \t' to `\t'. Instead we should convert
` \t' to `\t '. (where \t is the TAB character, of course)
2003-05-22 Jim Meyering <address@hidden>
* lib/autoconf/functions.m4 (AC_FUNC_GETLOADAVG): Change [\t][\t]
in a sed LHS to [\t ][\t ], so each space *follows* a TAB, rather
than preceding it. Before, it was [ \t][ \t], but some tool
appears to have been overaggressive and mistakenly removed
those significant spaces-*before*-TABs.
Index: lib/autoconf/functions.m4
===================================================================
RCS file: /cvsroot/autoconf/autoconf/lib/autoconf/functions.m4,v
retrieving revision 1.76
diff -u -p -r1.76 functions.m4
--- lib/autoconf/functions.m4 17 May 2003 10:30:08 -0000 1.76
+++ lib/autoconf/functions.m4 22 May 2003 08:21:24 -0000
@@ -744,7 +744,7 @@ if test $ac_cv_func_getloadavg_setgid =
# If we got an error (system does not support symlinks), try without -L.
test -z "$ac_ls_output" && ac_ls_output=`ls -lg /dev/kmem`
ac_cv_group_kmem=`echo $ac_ls_output \
- | sed -ne ['s/[ ][ ]*/ /g;
+ | sed -ne ['s/[ ][ ]*/ /g;
s/^.[sSrwx-]* *[0-9]* *\([^0-9]*\) *.*/\1/;
/ /s/.* //;p;']`
])
- FYI: functions.m4: restore mistakenly removed spaces in sed LHS,
Jim Meyering <=