[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: proposed autoconf patches for AS_BASENAME, AS_DIRNAME
From: |
Akim Demaille |
Subject: |
Re: proposed autoconf patches for AS_BASENAME, AS_DIRNAME |
Date: |
19 Oct 2001 17:04:28 +0200 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence) |
| OK, I checked it in with the above change. Testing revealed that
| one of our test cases was too enthusiastic, so I also checked in this
| change:
Thanks!
| @@ -100,27 +100,28 @@ AT_DATA_M4SH([script.as],
| # weak for us, in which case `as_expr=false'.
| m4_define([DIRNAME_TEST],
| [dir=`AS_DIRNAME([$1])`
| -test "$dir" = "$2" ||
| +test "$dir" = "$2" || (test -n "$3" && test "$dir" = "$3") ||
| echo "dirname($1) = $dir instead of $2" >&2
On a stylistic note, just to teach a bit of m4sugar
| +test "$dir" = "$2"m4_ifval([$3], [ || test "$dir" = "$3"]) ||
| echo "dirname($1) = $dir instead of $2" >&2