autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 60-fyi-wrappers.patch


From: Akim Demaille
Subject: Re: 60-fyi-wrappers.patch
Date: 03 Sep 2001 09:45:49 +0200
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence)

| > Tim> Minor nit: this should use $ac_path_separator, not ':'.  This is
| > Tim> non-obvious to the user though.
| > 
| > I was waiting for you :) :) :)  I swear I was :)
| 
| Heh - guess I'm well-established as the DOS advocate by now :)

:)

| > But we should probably have something like
| > 
| > AUTOTEST_PATH=`echo "$AUTOTEST_PATH" | tr ':' "$PATH_SEPARATOR"`
| > 
| > in test/general.m4.
| > 
| > That would make it, doesn't it?
| 
| Not quite:
| 
| AC_CONFIG_TESTDIR(blah, c:/my/path)

This doesn't make sense to me.  In AC_CONFIG_TESTDIR there should be
_only_ paths inside the package.  IMHO.


| Gee, I wonder why autotest is looking in 'c' and '/my/path'... :-)
| In some cases, the drivespec won't be so obvious; a configure.ac
| might have something like
| 
| AC_CONFIG_TESTDIR(tests, `cd $srcdir; pwd`)
| 
| which would result in a path with drivespec on DOS.

Even worse :)  Why on earth would you want that (except if you didn't
read the nonexistent Autotest documentation)?

    # Don't take risks: use only absolute directories in PATH.
    # AUTOTEST_PATH is expanded into build/src parts, since users
    # may create executables in both places.
    #
    # There might be directories that don't exist, but don't redirect
    # builtins' (eg., cd) stderr directly: Ultrix's sh hates that.
    at_IFS_save=$IFS
    IFS=$PATH_SEPARATOR
    at_sep=
    at_path=
    for at_dir in $AUTOTEST_PATH $PATH
    do
      case $at_dir in
        [[\\/]]* | ?:[[\\/]]* )
          if test -d "$at_dir"; then
            at_path="$at_path$at_sep$at_dir"
            at_sep=$PATH_SEPARATOR
          fi
          ;;
        * )
          at_build_dir=`(cd "$top_builddir/$at_dir" && pwd) 2>/dev/null`
          if test -d "$at_build_dir"; then
            at_path="$at_path$at_sep$at_build_dir"
            at_sep=$PATH_SEPARATOR
          fi
          at_src_dir=`(cd "$top_srcdir/$at_dir" && pwd) 2>/dev/null`
          if test -d "$at_src_dir"; then
            at_path="$at_path$at_sep$at_src_dir"
            at_sep=$PATH_SEPARATOR
          fi
          ;;
      esac
    done
    IFS=$at_IFS_save
    PATH=$at_path
    export PATH




reply via email to

[Prev in Thread] Current Thread [Next in Thread]