autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Remaining cleanup issues


From: Pavel Roskin
Subject: Remaining cleanup issues
Date: Mon, 2 Jul 2001 15:50:50 -0400 (EDT)

Hello!

I changed tests/mktests.sh so that the AC_REQUIREd macros are also tested
(just for myself, it's not in the patch).  There were 4 failures:
AC_INCLUDES_DEFAULT, AC_F77_LIBRARY_LDFLAGS, AC_PROG_CXX and
AC_PROG_CXXCPP.

Obviously, AC_INCLUDES_DEFAULT should not be used on the top level since
it doesn't expand to shell code.

AC_F77_LIBRARY_LDFLAGS calls _AC_PROG_F77_V_OUTPUT that removes
"conftest.*" after linking, thus leaving "conftest".

Both AC_PROG_CXX and AC_PROG_CXXCPP are indirectly calling
_AC_PROG_CXX_EXIT_DECLARATION, which uses "break" and doesn't clean up
after that.

ChangeLog:
        aclocal.m4 (_AC_PROG_CXX_EXIT_DECLARATION): Remove conftest*
        after using break.
        (_AC_PROG_F77_V_OUTPUT): Remove conftest*, not conftest.* after
        linking.

-------------------------------------------
--- aclang.m4
+++ aclang.m4
@@ -1227,6 +1227,7 @@
                                       [exit (42);])],
                      [break])
 done
+rm -f conftest*
 if test -n "$ac_declaration"; then
   echo '#ifdef __cplusplus' >>confdefs.h
   echo $ac_declaration      >>confdefs.h
@@ -1743,7 +1744,7 @@
 echo "$ac_f77_v_output" >&AS_MESSAGE_LOG_FD
 FFLAGS=$ac_save_FFLAGS

-rm -f conftest.*
+rm -f conftest*
 AC_LANG_POP(Fortran 77)dnl

 # If we are using xlf then replace all the commas with spaces.
-------------------------------------------

Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]