[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [patch] Fix for AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK
From: |
Tim Van Holder |
Subject: |
RE: [patch] Fix for AC_FUNC_LSTAT_FOLLOWS_SLASHED_SYMLINK |
Date: |
Tue, 22 May 2001 19:02:35 +0200 |
> Thanks Tim!
> FWIW, I prefer #2, but with this tiny addition:
>
> AC_REQUIRE([AC_PROG_LN_S])dnl
Err, no - $as_nl_s is set up unconditionally at startup
(_AS_LN_S_PREPARE, called from AS_SHELL_SANITIZE).
Using $ac_ln_s (or $LN_S, or whatever) would break the test, as
those can be overridden by the user; $as_ln_s is always set up to
be the working alternative to 'ln -s'.
> By the way, it's a little easier to browse/compare substantive changes
> (like your fix) if they're separate from the cleaning-up ones
> like s/conftest/conf$$/.
Sure, but I figured this was a small enough change (though I did
make a mistake in #1: the .sym wasn't removed from the string literal
in the C code).