[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch] Some more DOS compatibility
From: |
Akim Demaille |
Subject: |
Re: [Patch] Some more DOS compatibility |
Date: |
13 Mar 2001 14:03:12 +0100 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley) |
Tim, a few comments if you want to submit this again.
| Index: acgeneral.m4
| ===================================================================
| RCS file: /cvs/autoconf/acgeneral.m4,v
| retrieving revision 1.694
| diff -u -r1.694 acgeneral.m4
| --- acgeneral.m4 2001/02/07 15:04:52 1.694
| +++ acgeneral.m4 2001/02/16 17:41:09
| @@ -706,7 +706,7 @@
| ac_hostname=`(hostname || uname -n) 2>/dev/null | sed 1q`
|
| # Name of the executable.
| -as_me=`echo "$[0]" | sed 's,.*/,,'`
| +as_me=`echo "$[0]" | sed 's,.*[[\\/]],,'`
OK. Actually, implementing AS_BASENAME would be good.
| # Try the directory containing this script, then its parent.
| ac_prog=$[0]
| - ac_confdir=`echo "$ac_prog" | sed 's%/[[^/][^/]]*$%%'`
| + ac_confdir=`echo "$ac_prog" | sed 's%[[\\/][^\\/][^\\/]]*$%%'`
Huh? Why three chars now?
| echo "$as_me: exit $exit_status" >&AS_MESSAGE_LOG_FD
| - rm -rf conftest* confdefs* core core.* *.core $ac_clean_files &&
| - exit $exit_status
| + rm -rf conftest* confdefs* core core.* *.core $ac_clean_files && \
| + exit $exit_status
I see no point in this change.
| -srcdir=$srcdir
| +
| +dnl Add the quotes to protect paths with spaces/backslashes/etc
| +srcdir='$srcdir'
Good. While you're at it, I think the other guy around should have
single quotes too, not double (referring to INSTALL for instance).
- Re: [Patch] Some more DOS compatibility,
Akim Demaille <=