autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

FYI: Ultrix autotest/autoconf problem fix


From: Akim Demaille
Subject: FYI: Ultrix autotest/autoconf problem fix
Date: 28 Feb 2001 10:40:23 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley)

Harlan, I think this will fix your issue.  Thanks for the report!

Index: ChangeLog
from  Akim Demaille  <address@hidden>
        * tests/atgeneral.m4 (AT_INIT): Warn when at-check-line is
        missing.
        * tests/tools.at (Syntax of the scripts): Use AT_CHECK to test
        /bin/sh -n.  Exit 77 on failure.
        Reported by Harlan Stenn.

Index: tests/atgeneral.m4
===================================================================
RCS file: /cvs/autoconf/tests/atgeneral.m4,v
retrieving revision 1.57
diff -u -u -r1.57 atgeneral.m4
--- tests/atgeneral.m4 2001/01/30 19:29:40 1.57
+++ tests/atgeneral.m4 2001/02/28 09:31:51
@@ -225,6 +225,14 @@
     continue
     ;;
   esac
+  if test ! -f at-check-line; then
+    echo "$am_me: warning: no at-check-line which means a failure happened"
+    echo "$am_me: warning: in a [AT_SETUP/AT_CLEANUP] pair before any"
+    echo "$am_me: warning: AT_CHECK could be run.  This test suite is"
+    echo "$am_me: warning: improperly designed, please report to"
+    echo "$am_me: warning: <$at_bugreport>."
+    cp at-setup-line at-check-line
+  fi
   case $at_test in
     banner-*) ;;
     *)
Index: tests/tools.at
===================================================================
RCS file: /cvs/autoconf/tests/tools.at,v
retrieving revision 1.25
diff -u -u -r1.25 tools.at
--- tests/tools.at 2001/02/21 08:59:24 1.25
+++ tests/tools.at 2001/02/28 09:31:51
@@ -45,22 +45,24 @@
 if kill $! >/dev/null 2>&1; then
   # We managed to kill the child, which means that we probably
   # can't trust `/bin/sh -n', hence the test failed.
-  exit 1
+  exit 77
 fi
 ]])
 
-if /bin/sh ./syntax.sh; then
-  # Specify the path to the tool, some shells don't honor PATH
-  # when running `sh PROG'.
-  AT_CHECK([/bin/sh -n ../autoconf],   0)
-  AT_CHECK([/bin/sh -n ../autoreconf], 0)
-  AT_CHECK([/bin/sh -n ../ifnames],    0)
+# If we can't trust sh, just skip.
+AT_CHECK([/bin/sh ./syntax.sh])
 
-  # These are not built, they are in the src tree.
-  AT_CHECK([/bin/sh -n $top_srcdir/install-sh], 0)
-  AT_CHECK([/bin/sh -n $top_srcdir/mkinstalldirs], 0)
-  AT_CHECK([/bin/sh -n $top_srcdir/missing], 0)
-fi
+# Specify the path to the tool, some shells don't honor PATH when
+# running `sh PROG'.
+
+AT_CHECK([/bin/sh -n ../autoconf],   0)
+AT_CHECK([/bin/sh -n ../autoreconf], 0)
+AT_CHECK([/bin/sh -n ../ifnames],    0)
+
+# These are not built, they are in the src tree.
+AT_CHECK([/bin/sh -n $top_srcdir/install-sh], 0)
+AT_CHECK([/bin/sh -n $top_srcdir/mkinstalldirs], 0)
+AT_CHECK([/bin/sh -n $top_srcdir/missing], 0)
 
 AT_CLEANUP
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]