Re: [patch] remove config.status race condition

[Akim Demaille]

"Tim Van Holder" <address@hidden> writes:

> > First of all, it is not obvious at all that config.status should run
> > this, since Tim still did not convince me that AS_LN_S was a good
> > thing.  As is, AS_LN_S is just *useless*.  We were happier before.
> Hmm:
> 
> CONFIG_LINKS code BEFORE:
>   ln -s foo bar || ln foo bar
> 
> fine, but breaks DJGPP, where the 'ln -s' will succeed, but create a
> .exe file instead of the desired link.
> 
> CONFIG_LINKS code AFTER:
>   $as_ln_s foo bar || ln foo bar
>   (should be just $as_ln_s foo bar really, but the '|| ln does no harm')
> 
> This does EXACTLY the same thing as the "BEFORE" code (except it uses
> the proper command on systems with a broken or missing 'ln -s').
> So why were you happier before?
> 
> So why is it useless?  It doesn't break anything, but supports MORE
> targets!  I really don't see a reason for your reluctance.

Because it will break config.status on systems that don't support
symlinks.

Read the code closely, it is not

        ln -s foo bar || ln foo bar

it is

  ln -s $ac_rel_source $ac_dest 2>/dev/null ||
    ln $srcdir/$ac_source $ac_dest ||

ln -s is very different from ln and cp wrt its arguments.

Jim had once to teach me this because I meant to do a patch similar to
yours :)

If you want the same code, basically you need to first cd in the dest
rep.