autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for autoconf/145


From: Akim Demaille
Subject: Re: Patch for autoconf/145
Date: 23 Feb 2001 18:58:35 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Cuyahoga Valley)

Pavel Roskin <address@hidden> writes:

> Well, it were my words. After a long consideration I'm now in favor of the
> Derek's patch.
> 
> I've made few modifications:
> 
> Multiline sed scripts are portable. Add line breaks.
> No need to match spaces after "=" in the first pattern.
> Don't delete lines - make them empty as discussed before.
> Comment changes.
> 
> __________________________
> --- ChangeLog
> +++ ChangeLog
> @@ -1,3 +1,10 @@
> +2001-01-31  Pavel Roskin  <address@hidden>
> +
> +     * acgeneral.m4 (AC_OUTPUT): Remove $(srcdir), ${srcdir} and
> +     @srcdir@ from VPATH if srcdir is "." and replace blank VPATH
> +     lines with empty lines to preserve line numbers.
> +     Original version by Derek Price.
> +
>  2001-01-30  Ralf Corsepius <address@hidden>
> 
>       * acgeneral.m4 (_AC_OUTPUT_SUBDIRS): Remove configure.ac
> --- acgeneral.m4
> +++ acgeneral.m4
> @@ -3500,10 +3500,19 @@
>  # Let make expand exec_prefix.
>  test "x$exec_prefix" = xNONE && exec_prefix='${prefix}'
> 
> -# VPATH is dangerous, but if there is a colon in the path, we need to
> -# keep it.
> +# VPATH may cause troubles with some makes, so we remove $(srcdir),
> +# ${srcdir} and @srcdir@ from VPATH if srcdir is ".", strip leading and
> +# trailing colons and then remove the whole line if VPATH becomes empty
> +# (actually we leave an empty line to preserve line numbers).
>  if test "x$srcdir" = x.; then
> -  ac_vpsub=['/^[     ]*VPATH[        ]*=[^:]*$/d']
> +  ac_vpsub=['/^[     ]*VPATH[        ]*=/{
> +s/:*\$(srcdir):*/:/;
> +s/:*\${srcdir}:*/:/;
> +s/:address@hidden@:*/:/;
> +s/^\([^=]*=[         ]*\):*/\1/;
> +s/:*$//;
> +s/^[^=]*=[   ]*$//;
> +}']
>  fi

Why not, I have no strong opinion.

I have one desire though: avoid any kind of magic.  Why do we have to
do all this, I have still not understood.  If the user wants to shoot
in its foot, then Autoconf should not prevent it.

Now, Automake issues that VPATH.  Why?  Why don't we have the same
approach as for any other variable: AC_SUBST?  Yep, OK, there is the
problem of *completely* getting rid of VPATH.  Then how about the
approach used with SET_MAKE?  Or with AMDEP?

@address@hidden = @VPATH

or

@SET_VPATH@



Really, I have not understood why we needed something particular about
VPATH :(  I dislike very much black magic as above.  Which is not a
`no', just a `yuck'.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]