[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for autoconf/145
From: |
Alexandre Oliva |
Subject: |
Re: Patch for autoconf/145 |
Date: |
31 Jan 2001 02:05:37 -0200 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Crater Lake) |
On Jan 31, 2001, Alexandre Oliva <address@hidden> wrote:
> On Jan 29, 2001, Pavel Roskin <address@hidden> wrote:
>> +# VPATH is dangerous, so comment remove it if it's just @address@hidden
>> + ac_vpsub=['s/^[ ]*VPATH[ ]*=[ address@hidden@[ ]*$//']
> What if srcdir contains odd characters such as sed-rx meta-characters
> or slashes? :-D
Doh! For some reason, I thought @srcdir@ would have been replaced by
$srcdir.
I suggest accepting a few other variants: $(srcdir) and ${srcdir}.
And I like the idea of prefixing VPATH instead of blanking out the
line. Maybe just pre-pending `#', since the regexp ensures the line
won't end with a backslash?
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer address@hidden, redhat.com}
CS PhD student at IC-Unicamp address@hidden, gnu.org}
Free Software Evangelist *Please* write to mailing lists, not to me