Re: configure -q does not work

[Alexandre Duret-Lutz]

>>> "Akim" == Akim Demaille <address@hidden> writes:

 >>>>>> "adl" == Alexandre Duret-Lutz <address@hidden> writes:
 adl> The --silent option does not works in configures generated by
 adl> autoconf 2.49b (and CVS too, I assume): the $silent variable is
 adl> checked before allocating the file descriptors but the command
 adl> line arguments parsing (and thus $silent setting) is done later.

 Akim> I'm pretty sure you'll know how to fix that and how to send it to
 Akim> autoconf-patches ;)

 Akim> And I'm sure you'll find it fun to write a test case too :)

Index: ChangeLog
from  Alexandre Duret-Lutz  <address@hidden>

        configure -q did not work since 2000-11-03.

        * acgeneral.m4 (_AC_INIT_DEFAULTS_FDS): Don't check for $silent,
        tie AS_MESSAGE_FD to stdout unconditionally.
        (_AC_INIT_PARSE_ARGS): Don't define the silent variable, tie
        AS_MESSAGE_FD to /dev/null if requested.
        * tests/base.at (AC_CACHE_CHECK): New test.

Index: acgeneral.m4
===================================================================
RCS file: /cvs/autoconf/acgeneral.m4,v
retrieving revision 1.676
diff -u -r1.676 acgeneral.m4
--- acgeneral.m4 2001/01/24 07:50:56 1.676
+++ acgeneral.m4 2001/01/24 08:40:32
@@ -684,14 +684,10 @@
 # 0 standard input
 # 1 file creation
 # 2 errors and warnings
address@hidden:@ AS_MESSAGE_FD checking for... messages and results
 @%:@ AS_MESSAGE_LOG_FD compiler messages saved in config.log
-if test "$silent" = yes; then
-  exec AS_MESSAGE_FD>/dev/null
-else
-  exec AS_MESSAGE_FD>&1
-fi
address@hidden:@ AS_MESSAGE_FD checking for... messages and results
 exec AS_MESSAGE_LOG_FD>>config.log
+exec AS_MESSAGE_FD>&1
 ])# _AC_INIT_DEFAULTS_FDS
 
 
@@ -856,7 +852,6 @@
 program_prefix=NONE
 program_suffix=NONE
 AC_SUBST(program_transform_name, [s,x,x,])dnl
-silent=
 site=
 srcdir=
 verbose=
@@ -1077,7 +1072,7 @@
 
   -q | -quiet | --quiet | --quie | --qui | --qu | --q \
   | -silent | --silent | --silen | --sile | --sil)
-    silent=yes ;;
+    exec AS_MESSAGE_FD>/dev/null ;;
 
   -sbindir | --sbindir | --sbindi | --sbind | --sbin | --sbi | --sb)
     ac_prev=sbindir ;;
Index: tests/base.at
===================================================================
RCS file: /cvs/autoconf/tests/base.at,v
retrieving revision 1.12
diff -u -r1.12 base.at
--- tests/base.at 2001/01/23 12:53:54 1.12
+++ tests/base.at 2001/01/24 08:40:32
@@ -194,3 +194,24 @@
 AT_CHECK_CONFIGURE
 
 AT_CLEANUP
+
+
+## -------------- ##
+## AC_CACHE_CHECK ##
+## -------------- ##
+
+# make sure AC_CACH_CHECK is silent with -q
+
+AT_SETUP([AC_CACHE_CHECK])
+
+AT_DATA([configure.ac],
+[[AC_INIT
+AC_CACHE_CHECK([for nothing],[ac_nothing],[ac_nothing=found])
+]])
+
+AT_CHECK_AUTOCONF
+AT_CHECK([./configure -q], 0)
+AT_CHECK_CONFIGURE([], 0, [checking for nothing... found
+])
+
+AT_CLEANUP