Re: 94-as-literal-if.patch

[Pavel Roskin]

Hello, Akim!

> 95-as-box.patch
>   I wanted more flexibility with the banners, hence a macro was welcome.
>   In addition this is the first time I use Sed's `x' and `h', which was
>   quite fun.

Let's hope that it's portable, otherwise debugging the problems with some
old unices will be even more fun.

> Index: 0.561/ChangeLog
> from  Akim Demaille  <address@hidden>
>       * acgeneral.m4 (AC_VAR_INDIR_IFELSE): Move as...
>       * m4sh.m4 (AS_LITERAL_IF): this.
>       (AS_IFELSE): Rename as...
>       (AS_IF): this.

Ok.

> -                [$4])dnl
> +      [$4])[]dnl

I don't think the square brackets before dnl make any difference. But they
make the code harder to read. Unlike things like AC_MSG_RESULT([no]), that
can eventually grow to AC_MSG_RESULT([no, don't even ask]) I see no way
how this expression can be changed so that the brackets become
significant. No sane person will expect e.g. "fidnl" to work.

> -m4_ifvaln([$3],[$3])dnl])
> +m4_ifvaln([$3],[$3])dnl])[]dnl

See above.

> +# This is an *approximation*: for instance EXPRESSION = `\$' is
> +# definitely a literal, but will not be recognized as so.

as such.

Regards,
Pavel Roskin