autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Reducing "badness" for TeX


From: Akim Demaille
Subject: Re: Reducing "badness" for TeX
Date: 24 Nov 2000 10:44:05 +0100
User-agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.1 (Channel Islands)

| @@ -1910,9 +1910,9 @@
|  current value of @code{prefix}.
| 
|  A corollary is that you should not use these variables but in
| -Makefiles.  For instance instead of trying to resolve the dependencies
| -of @code{datadir} upon @code{prefix} and using
| address@hidden(DATADIR, "$datadir")}, you should add
| +Makefiles.  For instance, instead of trying evaluate @code{datadir}

Isn't it `trying _to_ do sth'?

| +in @file{configure} and hardcoding it in Makefiles using
| +e.g. @samp{AC_DEFINE_UNQUOTED(DATADIR, "$datadir")}, you should add
|  @samp{-DDATADIR="$(datadir)"} to your @code{CFLAGS}.
| 
|  Similarly you should not rely on @code{AC_OUTPUT_FILES} to replace



| @@ -5320,9 +5320,14 @@
|  @end example
| 
|  Therefore a portable solution to neutralize @samp{CDPATH} is
| address@hidden@address@hidden:}.  Note that since @command{zsh}
| -support @command{unset}, you may unset @samp{CDPATH} using @samp{:} as a
| -fall back, see @ref{Limitations of Builtins}.
| +
| address@hidden
| address@hidden@}:
| address@hidden example
| +
| +Note that since @command{zsh} supports @command{unset}, you may unset

I'd put a @noindent here.

| address@hidden using @samp{:} as a fallback, see
| address@hidden of Builtins}.
| 
|  @item LANG
|  @itemx LC_ALL

| @@ -8012,10 +8017,11 @@
|  @example
|  transform = @@program_transform_name@@
|  install: all
| -        $(INSTALL_PROGRAM) myprog $(bindir)/`echo myprog|sed '$(transform)'`
| +        $(INSTALL_PROGRAM) myprog $(bindir)/`echo myprog | \
| +          sed '$(transform)'`

How about

| +        $(INSTALL_PROGRAM) myprog \
| +                           $(bindir)/`echo myprog | sed '$(transform)'`
 
It seems for readable.  Or, if you want to keep it as it was, I'd
suggest indenting the sed on its echo:

| +        $(INSTALL_PROGRAM) myprog $(bindir)/`echo myprog | \
| +                                               sed '$(transform)'`


| @@ -8025,12 +8031,13 @@
|  PROGRAMS = cp ls rm
|  install:
|          for p in $(PROGRAMS); do \
| -          $(INSTALL_PROGRAM) $$p $(bindir)/`echo $$p|sed '$(transform)'`; \
| +          $(INSTALL_PROGRAM) $$p $(bindir)/`echo $$p | \
| +            sed '$(transform)'`; \

Likewise.


|  @defmac AC_LINK_FILES (@address@hidden, @address@hidden)
| @@ -8826,8 +8832,8 @@
|  @defmac AC_LONG_64_BITS
|  @maindex LONG_64_BITS
|  @cvindex LONG_64_BITS
| -If the C type @code{long int} is 16 bits wide, define
| address@hidden  Use @samp{AC_CHECK_SIZEOF(long int)} instead.
| +Define @code{LONG_64_BITS} if the C type @code{long int} is 64 bits wide.
| +Use more generic @samp{AC_CHECK_SIZEOF([long int])} instead.

Is this sentence correct?  I mean, this is a true question, I'm
surprised by the structure of the sentence, but it may well be that my
English grammar is not rich enough.





Great work Pavel!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]