autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AC_CHECK_TOOL doesn't work with cached values


From: Pavel Roskin
Subject: Re: AC_CHECK_TOOL doesn't work with cached values
Date: Sun, 29 Oct 2000 22:10:18 -0500 (EST)

Hello, Jim!

>       * acgeneral.m4 (AC_CHECK_TOOL): Set $1 also when using the cache.
>       Without this change, AC_PROG_RANLIB wouldn't work (wouldn't define
>       RANLIB) when ac_cv_prog_RANLIB was defined in the cache.

I think the same needs to be done for AC_PATH_TOOL. Maybe some day in the
future it will be possible to factorize the code for both macros, but
until then we should keep them in-sync.

You probably don't need to describe bad things in the ChangeLog as long as
they can be trivially deduced :-)

        * acgeneral.m4 (AC_CHECK_TOOL): Set $1 also when using the cache.
        (AC_PATH_TOOL): Likewise.

________________________
Index: acgeneral.m4
--- acgeneral.m4        Sun Oct 29 20:00:08 2000
+++ acgeneral.m4        Sun Oct 29 20:58:51 2000
@@ -3112,6 +3112,8 @@
   ac_pt_$1=$$1
   AC_PATH_PROG([ac_pt_$1], [$2], [$3], [$4])
   $1=$ac_pt_$1
+else
+  $1="$ac_cv_path_$1"
 fi
 ])# AC_PATH_TOOL
 
@@ -3127,6 +3129,8 @@
   ac_ct_$1=$$1
   AC_CHECK_PROG([ac_ct_$1], [$2], [$2], [$3], [$4])
   $1=$ac_ct_$1
+else
+  $1="$ac_cv_prog_$1"
 fi
 ])# AC_CHECK_TOOL
 
________________________

Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]