Re: AUCTeX doesn't build with latest Emacs master

[Arash Esbati]

Tassilo Horn <tsdh@gnu.org> writes:

> Arash Esbati <arash@gnu.org> writes:
>
>> Running make still doesn't ignore the files and `loaddefs-generate'
>> rifles through all .el files.  What am I missing?
>
> A bug in emacs, I think!  In loaddefs-generate, there's this code:
>
>           (setq defs (nconc
>                     (loaddefs-generate--parse-file
>                        file output-file
>                        ;; We only want the package name from the
>                        ;; excluded files.
>                        (and include-package-version
>                             (if (member (expand-file-name file) 
> excluded-files)
>                                 'only
>                               t)))
>
>
> I think the comment suggest that actually instead of expand-file-name,
> file-name-nondirectory was intended to be used here.

I agree, it seems like a bug in Emacs.  But I think the issue is that we
don't supply the `include-package-version' argument, hence, the
excluded-file part is not evaluated at all.  I'm not sure if that's the
way it was intended.

> Could you please report that?

Already did, bug#57144.  It started as a docstring report but now we're
getting to the meat ;-)[1]

> I'm almost in my holidays.  You could as well ask about the suggested
> upgrade path for packages that used the now obsolete autoloads.el as
> we did.

Will do.

> BTW, another approach (for the future) could be this:
>
> loaddefs-generate is a native-compiled Lisp function in ‘loaddefs-gen.el’.
>
> (loaddefs-generate DIR OUTPUT-FILE &optional EXCLUDED-FILES EXTRA-DATA
> INCLUDE-PACKAGE-VERSION GENERATE-FULL)
>
> [...]  If any Lisp file binds ‘generated-autoload-file’ as a file-local
> variable, write its autoloads into the specified file instead.

Yes, I played with that as well and that works.  I just wasn't sure what
that means for the ELPA releases you prepare.  So I thought we try the
excluded-files version first.

Do you think you can make an ELPA release before you leave?  Enjoy your
holidays.

Best, Arash

Footnotes:
[1]  https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-08/msg01067.html