[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: defcustoms in styles
From: |
Arash Esbati |
Subject: |
Re: defcustoms in styles |
Date: |
Sat, 18 Jan 2020 23:51:34 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 |
Ikumi Keita <address@hidden> writes:
>>>>>> Arash Esbati <address@hidden> writes:
>> For the start, is there any particular reason for shortvrb.el containing
>> the variable? I don't see one. The way I see it `LaTeX-shortvrb-chars'
>> can be moved to tex-style.el.
>
> I don't see, either. I think it's OK to move it to tex-style.el.
Thanks for confirming.
> By the way, following code in `TeX-add-style-hook' part seems a bit
> strange to me:
> ----------------------------------------------------------------------
> (when (and LaTeX-shortvrb-chars
> (fboundp 'font-latex-set-syntactic-keywords)
> (eq TeX-install-font-lock 'font-latex-setup))
> (font-latex-add-to-syntax-alist
> [...]
> ----------------------------------------------------------------------
> I think this `fboundp' test is a mistake of
> (fboundp 'font-latex-add-to-syntax-alist)
Yes, you're right. I've overlooked that one.
> And if we modify the code in this way, `declare-function' about
> `font-latex-add-to-syntax-alist' in the former half of this file can
> be omitted.
I went another route and changed
(fboundp 'font-latex-set-syntactic-keywords)
to our standard procedure
(featurep 'font-latex)
Hence, the `declare-function' is still necessary. But thanks for
pointing out this issue.
Best, Arash