acl-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Acl-devel] [ATTR] [PATCH] Cleanup visibility of API functions


From: Yury Usishchev
Subject: [Acl-devel] [ATTR] [PATCH] Cleanup visibility of API functions
Date: Wed, 02 Mar 2016 17:14:03 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Hello!

As discussed in 
http://lists.nongnu.org/archive/html/acl-devel/2016-02/msg00000.html thread 
I've prepared patch set for
cleaning up visibility of API functions in attr.

0001-Cleanup-config.h-usage.patch:

  adds config.h include before all other includes in all source files.

0002-Cleanup-visibility-of-API-functions.patch:

  add m4 script from acl tree that checks for visibility attribute.
  add call to new m4 macro from configure.ac
  add visibility attribute to API functions same way it was added in acl.

Note: functions from syscalls.c are exported through linker script libattr.lds 
and visibility needs to be set explicitly
Note2: pragma usage in syscalls.c seems cleaner
Note3: internal headers usage cleanup in attr was not needed

Could you review attached patches please?

BR,
Yury Usishchev

Attachment: 0001-Cleanup-config.h-usage.patch
Description: 0001-Cleanup-config.h-usage.patch

Attachment: 0002-Cleanup-visibility-of-API-functions.patch
Description: 0002-Cleanup-visibility-of-API-functions.patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]