Re: [wdiff-bugs] Bug#583000: bashism in configure script makes build to fail

[Martin von Gagern]

Dear Santiago,

On 25.05.2010 13:15, Santiago Vila wrote:
> I received this report from the Debian bug system.
> 
> It seems the root of the problem is a bashism in the configure script.
> Patch follows.

On 25.05.2010 13:34, Santiago Vila wrote:
> Hmm, this was already reported by Nelson Beebe, so I assume it's already
> fixed in the development version.

Right: fixed 2010-04-14 in revision 106 but not released yet.

I had hoped for a few additional translations to accompany that fix, but
there haven't been any new translations from TP in a long while, so I
guess I'll release the fix as 0.6.2 today.

> BTW: Adding the letter "x" reminds me of MS-DOS .BAT programming,
> where such trick was necessary. Should "$with_termcap" = "auto" not
> work well enough, even if $with_termcap is empty?

I assume it should, yes. But I don't know if this is really true for
every shell out there. A lot of tests in the configure script are
written this way (75 out of 187 at last count), and I assume there just
might be a good reason for it. So as the "x" version will always work, I
won't try fixing something that isn't broken, and leave it as it is.

Greetings,
 Martin

signature.asc
Description: OpenPGP digital signature