tsp-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: RE : [Tsp-devel] Patch pour le bug 1979


From: Robert de Vries
Subject: Re: RE : [Tsp-devel] Patch pour le bug 1979
Date: Tue, 13 Mar 2007 14:09:07 +0100
User-agent: Thunderbird 1.5.0.10 (X11/20070301)

ALAUX, Virginie wrote:
Bonjour,

J'ai la version TSP 8.0.2
Je te joins le code tsp_session.c auquel j'ai appliqué le patch bug19179-erk1.patch avec la 
commande "patch -pN < bug19179-erk1.patch"

Le code :


Code snippet removed...
A la ligne 754:
    STRACE_INFO(("Garbage Collector thread found Datapool TERMINATED for session 
<%d>",X_session_t[i].channel_id));
Je pense que cette trace n'est pas incluse dans les accolades du if...
Donc j'ai l'erreur : syntax error.
This is indeed an obvious syntax error. But I can put the blame on Eric ( ;-) ) for not providing a context diff (or unified diff) patch. The patch he provides patches without warning, but the patch application does not have any context to work with so it literally replaces and adds the lines in the patch on the lines specified in the patch file. This will not give the expected results except for the specific version of Eric. (next time do diff -u)
It would be easier to just update to the CVS version.

   Robert

--
Robert H. de Vries      mailto:address@hidden
AS&E/SW                     http://www.eurosim.nl
Dutch Space B.V.        http://www.dutchspace.nl
tel: (+31)71-5245464    fax: (+31)71-5245498





reply via email to

[Prev in Thread] Current Thread [Next in Thread]