Re: [Traverso-devel] Splitting Clips With Fades

[Remon]

> I've slimmed down this patch, and it works the same way:  Fine except
> during transport, when both fades on both resulting clips are lost
> during a split.  Any idea why the outer fades go away with this patch,
> when splitting during playback?

Ah, I did an interesting observation, it happened too without the patch. After 
looking around on the command line it mentioned it was adding the nodes of 
the fadecurve in a thread save way when the fade was constructed.
Setting the range then fails, and the range gets resetted to 0....

I've made a fix, and merged the SplitClip part, however, I'm still not sure 
how to handle the resetting part.
Your patch removes the fade, which essentially creates a memory leak since the 
removed Fade never gets deleted.
Just keeping it as it is, setting the fade to a 0 range works as well.... ?

Regards,

Remon

>
> Ben
>
> On 4/25/07, Remon <address@hidden> wrote:
> > Hi Ben,
> >
> > As you became aware allready, fades never get removed really....
> > Perhaps it should work just like any other audio processing object with a
> > AddRemove command.
> >
> > The trick is that one doesn't alter the state of the object at all, so it
> > can be safely inserted again at some later point, that's how un/redo
> > works in Traverso.
> >
> > However you are removing the fades _and_ assign 0 to them....
> > Me thinks that's a bad idea ;-)
> >
> > Oh well, I've never been happy about 'resetting' a Fade, it used to be
> > done by setting the fade length to something very small...
> > So you could just do that for now, reset fade_in/out()
> >
> > And me wonders why he wrote all the docs, ah, it's not uploaded to the
> > website I guess. ResourcesManager has it's functions documented, and it
> > states getting a clip twice by it's id makes a deep copy...
> >
> > Regards,
> >
> > Remon
> >
> > > I've put together a patch to make splitting clips with a fade in
> > > and/or fade out work right.  (Attached.)
> > >
> > > However, it doesn't yet work quite right... :)
> > >
> > > It's very close.  It works right if you're not transporting.  But if
> > > you are, it clears not just the fades at the split point, but also
> > > clears the original start and end fades.
> > >
> > > I think this may have to do with the fact that the Clip is never
> > > really deep copied / cloned in SplitClip::prepare_actions()?
> > >
> > > Remon, do you have a quick fix?  :)
> > >
> > > Thanks,
> > > Ben
> >
> > _______________________________________________
> > Traverso-devel mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/traverso-devel