tinycc-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Tinycc-devel] 回复: Recent patches for the TinyCC 0.9.28 Release Candidat


From: kbkpbot
Subject: [Tinycc-devel] 回复: Recent patches for the TinyCC 0.9.28 Release Candidate
Date: Thu, 08 Feb 2024 11:19:25 +0800

I push a patch for stdatomic.c , use a MemoryBarrier macro define for it.
And the code has been tested under GCC and MSVC.
----- 原始邮件 -----
发件人:Detlef Riekenberg via Tinycc-devel <tinycc-devel@nongnu.org>
收件人:tinycc-devel@nongnu.org
抄送人:Detlef Riekenberg <wine.dev@web.de>, gr1008@gmail.com, Eric Raible <raible@gmail.com>, kbkpbot <kbkpbot@gmail.com>
主题:[Tinycc-devel] Recent patches for the TinyCC 0.9.28 Release Candidate
日期:2024年02月08日 09点50分

Hi TinyCC follower.
The current branch is a release candidate for TinyCC 0.9.28 since some month.
From the active people here, only grischka has the rights to make a release,
and I suggest, that we should help him to be comfortable to make a release by:
* more testing
* add only minimal fixes to the current mob branch to increase stability
* avoid to push any new features for now
I further suggest, that for any patch, which is longer than one or two lines,
the change should be discussed here before pushing.
@grischka
I tested your recent fixes:
The i386-tcc search path works now. Thanks
(I tested with a simple Hello_World for X11 and a simple ppm viewer for X11)
@Eric Raible:
A custom allocator is not a new idea.
TinyCC has already a custom allocator and uses it by default.
How often will it be useful for a libtcc user to force TinyCC
to use an application provided allocator?
You add an overhead for every user of TinyCC for every memory allocation/free.
My additional comments to your patch:
* it is a far to big change for a release candidate
* it needs a lot of testing
* it adds more complexity
#####
@kbkpbot
Yes, there are many things missing for atomic support,
but when i read your patch, i'm not sure,
if the code works with any windows compiler, which is incompatible to gcc.
(I changed my SSD and msvc is not installed yet, so I can't test that now)
Reason: "__attribute__" and "__asm__" are gcc extensions.
Are they supported by MSVC?
(Yes, i saw, that you mostly just moved the code around...)
+#ifndef __TINYC__
+void __atomic_signal_fence(int memorder) __attribute__((alias("__tcc_atomic_signal_fence")));
In the meantime, a macro for a fence can help
#####
I suggest to revert both changes (with the cleanup from @Herman)
and wait until @grischka pushes a release.
@grischka, what do you think about reverting everything after your cleanup patch
and then push a release?
--
Bye bye ... Detlef
_______________________________________________
Tinycc-devel mailing list
Tinycc-devel@nongnu.org
https://lists.nongnu.org/mailman/listinfo/tinycc-devel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]