Re: [Tinycc-devel] [PATCH] Add support for reading thin archive files.

[gz8cx4]

Hello Reimar,

On Sun, Oct 29, 2023 at 11:29:30PM +0100, Reimar Döffinger wrote:
> I sent this one to the list first instead of pushing,

Thanks, this is appreciated.

> because it's a lot uglier and less relevant than the
> changes I have done previously.
> So comments or objections welcome.

It would be helpful if adding code to tcc is accompanied with the
description of the problems the addition is supposed to solve.

The "thin archive" functionality is a means to somewhat optimize certain
kind of builds (those who use large build-time libraries never becoming
a part of the final data).

That's nice if tinycc will be able to efficiently build huge targets,
but adding features is usually irreversible and each addition makes tiny
to less tiny.

Would it be too much to ask for making this addition a compile-time choice?

(without having read into the code, a detail:
in the snippet
         if (0 == memcmp(h, ARMAG, 8))
             return AFF_BINTYPE_AR;
+        if (0 == memcmp(h, "!<thin>\n", 8))
+            return AFF_BINTYPE_AR;
"!<thin>\n" looks like a candidate for a symbolic name not unlike ARMAG ?)

Regards,
/tccm