Re: [Sks-devel] Bug: membership file too raw in stats page

[Phil Pennock]

On 2009-10-12 at 20:08 +0000, Kim Minh Kaplan wrote:
> Phil Pennock writes:
> 
> > One of my peers had a line in their membership file which followed the
> > common idiom of:
> >   host.example.net 11370    # Fred Bloggs <address@hidden>
> >
> > Unfortunately, they'd missed the '#' character.  The
> > /pks/lookup?op=stats page returned this raw with no HTML entity
> > escaping.
> 
> Although SKS could be more carefull with the escaping on the stats page
> I can not reproduce the problem you describe.  The peers table is built
> from the result of Membership.get_names() which uses a Scanf "%s %s".
> Only the hostname and service are used, the rest of the line is silently
> discarded.

http://keyserver.stack.nl:11371/pks/lookup?op=stats

It's running 1.1.0; that's using conver_address with a sscanf "%s %d";
however, membership holds (mshp, mtime) and mshp is an Array of tuples
where the first element is addr (host port) and the second is the line,
after comments have been removed.

Then Membership.get_names() is doing:
   Array.map ~f:snd mshp
to just return the lines, not the parsed data.  So as long as the line
*starts* "%s %d" then it will be stored.

Regards,
-Phil

pgpqbJb1smY3v.pgp
Description: PGP signature