On Sat, Aug 27, 2005 at 03:11:31PM -0400, Jason Harris wrote:
> On Sat, Aug 27, 2005 at 02:20:37PM +0200, Marco Nenciarini wrote:
> > On Fri, Aug 26, 2005 at 03:25:18PM -0400, Jason Harris wrote:
>
> > > > When you invoke sks cleandb the first time it creates the file
> > > > KDB/meta where is written that KDB database is clean. Any subsequent
> > > > invocation of sks cleandb return immediately without doing any
> > > > work.
> > > > Only deleting KDB/meta you can force another cleandb cycle.
> > >
> > > Indeed, and I never liked this EVIL(TM) misfeature. :) So, finally,
> > > here's a quick patch:
> > >
> > [snip patch]
> >
> > I made this more "politically correct" patch (attached).
> >
> > With this patch, you don't need to delete KDB/meta, but only specify
> > -force_cleaning on command line.
>
> This just overcomplicates things. When you need to run cleandb, you
> want it to just run. It isn't like build/fastbuild or pbuild, which
> actually protect you from destroying existing dbs. Even worse, and
> I've said this before on this list, "sks merge" doesn't filter,
> making cleandb necessary after merging.
This is a bad thing. If sks merge leave the KDB in an unclean state, I
think it should reset all filters stored in KDB/meta.
Yeah, "sks merge" is generally a hack, and not well supported. I
think Jason's idea of simply always reapplying all cleaners when doing
cleandb, is a good one, as is invalidating the meta flags. I'd
accept patches for btoh.
>
> So, what are you (first Yaron, and now Marco) protecting against?
>
Ok, I think you are right. ATM if an user run sks cleandb, it should
do its work.
Yaron, what do you think about?
Ciao
--
---------------------------------------------------------------------
| Marco Nenciarini | Debian/GNU Linux Developer - Plug Member |
| address@hidden | http://www.prato.linux.it/~mnencia
|
---------------------------------------------------------------------
Key fingerprint = FED9 69C7 9E67 21F5 7D95 5270 6864 730D F095 E5E4
-----BEGIN PGP SIGNATURE-----
Version: GnuPG
v1.4.1 (GNU/Linux)
iD8DBQFDEYeQaGRzDfCV5eQRAqNlAJ9sroqhrt/nbVSUBogW7DjmrRrP0ACghVOw
iBjCGT2gbDViamXkKyCL/YA=
=f8E5
-----END PGP SIGNATURE-----
_______________________________________________
Sks-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/sks-devel