[Savannah-dev] Re: etc_password_maxid too low

[mathieu]

Marcus Hardt <address@hidden> a tapoté :

> Hi!
>
> The bug occurs in here, because of the next if(....'anoncvs'....). I would 
> remove this line because I don't understand it. But since I don't understand 
> it, I'd better not remove it. :-)
>

You'd better not remove it :)

In fact, anoncvs is a system user and should not have a uid superior
to usual users.

As a matter of fact, this user should have been created first, before
running the script. Or created with an option -r (but it seems to be
RedHat specific). 

But there is an easy solution that I will apply ASAP, 

     $etc_password_maxid = $entry[2] > $etc_password_maxid ? $entry[2] : 
$etc_password_maxid;

just have to be before the next statement.


>
> Marcus.
>
> while (my @entry = getpwent()) {
>     push(@etc_users, $entry[0]);
>     next if($entry[0] eq 'anoncvs' || $entry[0] eq 'webcvs' || $entry[0] eq 
> 'nobody');
>     $etc_password{$entry[0]} = [ @entry ];
>     $etc_password_maxid = $entry[2] > $etc_password_maxid ? $entry[2] : 
> $etc_password_maxid;
>     print "DBG etc: user $entry[0]\t\t maxid $etc_password_maxid\n" if $debug;
> }
>
> -- 
> Marcus

-- 
mathieu

  [ http://meuh.coleumes.org      : Sans peur et sans... peur ]
  [ http://stock.coleumes.org/gpg : clef GnuPG ]