[Savannah-dev] [bug #5470] incorrect sql statement

[nobody]

=================== BUG #5470: FULL BUG SNAPSHOT ===================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5470&group_id=11

Submitted by: parser                  Project: Savannah                     
Submitted on: Mon 09/22/03 at 09:14
Category:  None                       Severity:  5 - Average                
Priority:  None                       Resolution:  None                     
Assigned to:  None                    Status:  Open                         
Fixed Release:                        

Summary:  incorrect sql statement

Original Submission:  Hi,



I have the DEV_CERN-BRANCH and found in the /include/user.php skript a wrong 
MySQL-Statement.

The ID is:

// $Id: user.php,v 1.8.2.4 2003/09/08 16:54:32 yeupou Exp $



In the original the only $admin_flags was set into simple 
quotes('$admin_flags'). This wasn´t working on my machine,  all variables have 
to do so.



The function "user_add_to_group" has to look like this:



function user_add_to_group($uid, $gid, $admin_flags, $bug_flags,

$forum_flags, $project_flags, $patch_flags, $support_flags, $doc_flags) {  

  $ret=1;

  // Check if user is in this group

  if(!user_is_group_member($uid,$gid)){

          db_query("INSERT INTO user_group (user_id, group_id, admin_flags,

             bug_flags, forum_flags, project_flags, patch_flags, support_flags,

             doc_flags) VALUES ('$uid', '$gid', '$admin_flags', '$bug_flags',

             '$forum_flags', '$project_flags', '$patch_flags', '$support_flags',

             '$doc_flags')") ||

    $feedback .=  "Error adding".$uid." to "."$gid. SQL string: 

             INSERT INTO user_group (user_id, group_id, admin_flags,

             bug_flags, forum_flags, project_flags, patch_flags, support_flags,

             doc_flags) VALUES ('$uid', '$gid', '$admin_flags', '$bug_flags',

             '$forum_flags', '$project_flags', '$patch_flags', '$support_flags',

             '$doc_flags')" &&

    $ret=0;

  }

  else{

          db_query("UPDATE user_group SET admin_flags='$admin_flags',

             bug_flags='$bug_flags', forum_flags='$forum_flags',

             project_flags='$project_flags', patch_flags='$patch_flags',

             support_flags='$support_flags',

             doc_flags='$doc_flags' WHERE user_id='$uid' AND group_id='$gid'") 
||

    $feedback .=  "Error updating".$uid." in ".$gid.". SQL string: 

             UPDATE user_group SET admin_flags='$admin_flags',

             bug_flags='$bug_flags', forum_flags='$forum_flags',

             project_flags='$project_flags', patch_flags='$patch_flags',

             support_flags='$support_flags',

             doc_flags='$doc_flags' WHERE user_id='$uid', group_id='$gid'" &&

    $ret=0;

  }

  return $ret;

}





No Followups Have Been Posted


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=5470&group_id=11

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/