[bug #21286] usability BUG: takeover user text string inconsistent with behaviour (fwd)

[boud]

> Subject: [bug #21286] usability BUG: takeover user text string
>     inconsistent with behaviour


URL:
  <http://savannah.nongnu.org/bugs/?21286>

                 Summary: usability BUG: takeover user text string
inconsistent with behaviour
                 Project: Samizdat
            Submitted by: boud
            Submitted on: Sunday 10/07/2007 at 17:30
                Category: None
                Severity: 3 - Normal
                  Status: Works For Me
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

PROBLEM: In 070818-1 (probably since the earlier refactoring),
the information given to the moderator when using the TAKE OVER
function says that the message will be attributed to that user
afterwards, but this is not true, since set_creator is not
used.  For the REPLACE function, no such info is given to the
moderator, but transparency e.g. in the message info and in
the history would suggest that the message *should* be attributed
to that moderator after the intervention.  Otherwise, the
intervention is only obvious in e.g. when using the /moderation
function.


SOLUTION:
Either the message about attribution should be changed, or
attribution should be implemented. My suggestion is to keep
the older behaviour (AFAIR) in which attribution is made,
and also do this for REPLACE.  If some people really don't want
this, then the question is whether they should have to edit
the ruby code or we should add this as a configurable parameter.

Any thoughts?

Anyway, here's the patch.

cheers
boud



--- /usr/lib/ruby/1.8/samizdat/controllers/message_controller.rb~
2007-10-07 19:14:49.479497088
+0200
+++ /usr/lib/ruby/1.8/samizdat/controllers/message_controller.rb
2007-10-07 19:19:35.010089840
+0200
@@ -336,6 +336,7 @@
     @message = Message.cached(@id)
     @message.assert_current_version

+    set_creator  # consistency with 'The message will be attributed to you
after takeover'
     set_content
     set_lang(@message.lang)
     set_desc
@@ -372,6 +372,7 @@
     assert_moderate

     @message = Message.cached(@id)
+    set_creator  # otherwise intervention is insufficiently transparent
     set_content
     set_lang(@message.lang)
     set_desc







    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sunday 10/07/2007 at 17:30  Name: takeover_transparency-0.1.patch
Size: 692B   By: boud

<http://savannah.nongnu.org/bugs/download.php?file_id=14111>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?21286>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/