[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[rdiff-backup-users] fsync-directories test results not put in place qui
From: |
Charles Duffy |
Subject: |
[rdiff-backup-users] fsync-directories test results not put in place quickly enough |
Date: |
Wed, 17 Aug 2005 09:52:10 -0500 |
Observe the following stack trace:
Directories on file system at /dev/shm/restore/rdiff-backup.tmp.5 are not
fsyncable.
Assuming it's unnecessary.
Unable to import module xattr.
Extended attributes not supported on filesystem at
/dev/shm/restore/rdiff-backup.tmp.5
Unable to import module posix1e from pylibacl package.
ACLs not supported on filesystem at /dev/shm/restore/rdiff-backup.tmp.5
Traceback (most recent call last):
File "/usr/bin/rdiff-backup", line 23, in ?
rdiff_backup.Main.Main(sys.argv[1:])
File "/usr/lib64/python2.3/site-packages/rdiff_backup/Main.py", line 282, in
Main
take_action(rps)
File "/usr/lib64/python2.3/site-packages/rdiff_backup/Main.py", line 261, in
take_action
elif action == "restore": Restore(*rps)
File "/usr/lib64/python2.3/site-packages/rdiff_backup/Main.py", line 482, in
Restore
restore_set_fs_globals(dest_rp)
File "/usr/lib64/python2.3/site-packages/rdiff_backup/Main.py", line 520, in
restore_set_fs_globals
target_fsa = target.conn.fs_abilities.get_fsabilities_readwrite(
File "/usr/lib64/python2.3/site-packages/rdiff_backup/fs_abilities.py", line
397, in get_fsabilities_readwrite
return FSAbilities(desc_string).init_readwrite(
File "/usr/lib64/python2.3/site-packages/rdiff_backup/fs_abilities.py", line
155, in init_readwrite
subdir.delete()
File "/usr/lib64/python2.3/site-packages/rdiff_backup/rpath.py", line 867, in
delete
if Globals.fsync_directories: self.fsync()
File "/usr/lib64/python2.3/site-packages/rdiff_backup/rpath.py", line 1056,
in fsync
if not fp: self.conn.rpath.RPath.fsync_local(self)
File "/usr/lib64/python2.3/site-packages/rdiff_backup/rpath.py", line 1063,
in fsync_local
os.fsync(fd)
OSError: [Errno 22] Invalid argument
Notably, part of the fs_abilities check is calling fsync_local(), which
is trying to fsync directories even though the test to determine
whether this could be safely done failed, because
Globals.fsync_directories has not yet been updated.
I propose defaulting fsync_directories to 0 until the
get_fsabilities_readwrite() results are used to update Globals.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [rdiff-backup-users] fsync-directories test results not put in place quickly enough,
Charles Duffy <=