[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_p
From: |
Peter Xu |
Subject: |
Re: [PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_prepend() |
Date: |
Fri, 1 Mar 2024 09:37:38 +0800 |
On Thu, Feb 29, 2024 at 10:39:11PM +0800, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> As the comment in qapi/error, passing @errp to error_prepend() requires
> ERRP_GUARD():
>
> * = Why, when and how to use ERRP_GUARD() =
> *
> * Without ERRP_GUARD(), use of the @errp parameter is restricted:
> ...
> * - It should not be passed to error_prepend(), error_vprepend() or
> * error_append_hint(), because that doesn't work with &error_fatal.
> * ERRP_GUARD() lifts these restrictions.
> *
> * To use ERRP_GUARD(), add it right at the beginning of the function.
> * @errp can then be used without worrying about the argument being
> * NULL or &error_fatal.
>
> ERRP_GUARD() could avoid the case when @errp is the pointer of
> error_fatal, the user can't see this additional information, because
> exit() happens in error_setg earlier than information is added [1].
>
> The migrate_params_check() passes @errp to error_prepend() without
> ERRP_GUARD(), and it could be called from migration_object_init(),
> where the passed @errp points to @error_fatal.
>
> Therefore, the error message echoed in error_prepend() will be lost
> because of the above issue.
>
> To fix this, add missing ERRP_GUARD() at the beginning of this function.
>
> [1]: Issue description in the commit message of commit ae7c80a7bd73
> ("error: New macro ERRP_GUARD()").
>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Fabiano Rosas <farosas@suse.de>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
Acked-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH 10/17] hw/vfio/pci: Fix missing ERRP_GUARD() for error_prepend(), (continued)
- [PATCH 10/17] hw/vfio/pci: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 11/17] hw/vfio/platform: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 12/17] hw/virtio/vhost-vsock: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 13/17] hw/virtio/vhost: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 15/17] net/vhost-vdpa: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 14/17] migration/option: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 16/17] target/i386/sev: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29
- [PATCH 17/17] target/s390x/cpu_models: Fix missing ERRP_GUARD() for error_prepend(), Zhao Liu, 2024/02/29