[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixe
|
From: |
Zhao Liu |
|
Subject: |
Re: [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config() |
|
Date: |
Thu, 29 Feb 2024 00:09:34 +0800 |
> No need to quote the dereferences in full.
>
> But in cxl_fixed_memory_window_config(), @errp is dereferenced in 2
> places without ERRP_GUARD().
>
> In these two places, we check "*errp", because neither function
>
> would do.
>
> Same for the other commit messages.
>
> Hardly worth a respin, though :)
>
I over-understood your reply. I'll pay attention to that in the follow
up.
Thanks,
Zhao
- [PATCH v2 0/7] Cleanup and fix @errp dereference, Zhao Liu, 2024/02/23
- [PATCH v2 1/7] hw/cxl/cxl-host: Fix missing ERRP_GUARD() in cxl_fixed_memory_window_config(), Zhao Liu, 2024/02/23
- [PATCH v2 2/7] hw/display/macfb: Fix missing ERRP_GUARD() in macfb_nubus_realize(), Zhao Liu, 2024/02/23
- [PATCH v2 3/7] hw/mem/cxl_type3: Fix missing ERRP_GUARD() in ct3_realize(), Zhao Liu, 2024/02/23
- [PATCH v2 4/7] hw/misc/xlnx-versal-trng: Check returned bool in trng_prop_fault_event_set(), Zhao Liu, 2024/02/23
- [PATCH v2 5/7] hw/pci-bridge/cxl_upstream: Fix missing ERRP_GUARD() in cxl_usp_realize(), Zhao Liu, 2024/02/23
- [PATCH v2 6/7] hw/vfio/iommufd: Fix missing ERRP_GUARD() in iommufd_cdev_getfd(), Zhao Liu, 2024/02/23
- [PATCH v2 7/7] hw/intc: Check @errp to handle the error of IOAPICCommonClass.realize(), Zhao Liu, 2024/02/23