|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH 0/7] hw/i386: Cleanups around 'hw/i386/pc.h' |
Date: | Tue, 13 Feb 2024 17:00:26 +0100 |
User-agent: | Mozilla Thunderbird |
On 13/2/24 16:55, Michael S. Tsirkin wrote:
On Tue, Feb 13, 2024 at 01:01:45PM +0100, Philippe Mathieu-Daudé wrote:Trivial patches removing uses of "hw/i386/pc.h".How did you test that it's indeed unused?
I put and #error in hw/i386/pc.h and built :) (I'm trying to remove the PC dependency on generic devices.) The few generic devices left are not as trivial.
Philippe Mathieu-Daudé (7): target/i386/monitor: Remove unused 'hw/i386/pc.h' header hw/timer: Move HPET_INTCAP definition to "hpet.h" hw/isa/lpc_ich9: Remove unused 'hw/i386/pc.h' hw/i386/acpi: Declare pc_madt_cpu_entry() in 'acpi-common.h' hw/i386/port92: Add missing 'hw/isa/isa.h' header hw/acpi/cpu_hotplug: Include 'pci_device.h' instead of 'pci.h' hw/acpi/cpu_hotplug: Include 'x86.h' instead of 'pc.h' hw/i386/acpi-common.h | 3 +++ include/hw/i386/pc.h | 6 ------ include/hw/timer/hpet.h | 2 ++ hw/acpi/cpu_hotplug.c | 4 ++-- hw/i386/acpi-common.c | 1 - hw/i386/port92.c | 1 + hw/isa/lpc_ich9.c | 1 - hw/timer/hpet.c | 1 - target/i386/monitor.c | 1 - 9 files changed, 8 insertions(+), 12 deletions(-) -- 2.41.0
[Prev in Thread] | Current Thread | [Next in Thread] |