Re: [PATCH 1/3] cpu-target: Include missing 'exec/memory.h' header

[Philippe Mathieu-Daudé]

On 9/2/24 17:01, Peter Maydell wrote:
> On Fri, 9 Feb 2024 at 15:01, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> > Include "exec/memory.h" in order to avoid:
> >
> >    cpu-target.c:201:50: error: use of undeclared identifier 'TYPE_MEMORY_REGION'
> >        DEFINE_PROP_LINK("memory", CPUState, memory, TYPE_MEMORY_REGION,
> >                                                     ^
>
> Given that we don't actually see this error, presumably
> we're implicitly dragging it in via some other include?

It is pulled in by the exec/cpu-all.h header which I'm trying to
sanitize (along with others). I'll add a note about this.

> Anyway, better to be explicit than implicit, so
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Thanks!