Re: [PATCH 06/10] m68k: Clean up includes

[Zhao Liu]

On Thu, Jan 25, 2024 at 04:34:04PM +0000, Peter Maydell wrote:
> Date: Thu, 25 Jan 2024 16:34:04 +0000
> From: Peter Maydell <peter.maydell@linaro.org>
> Subject: [PATCH 06/10] m68k: Clean up includes
> X-Mailer: git-send-email 2.34.1
> 
> This commit was created with scripts/clean-includes:
> ./scripts/clean-includes --git m68k include/hw/audio/asc.h include/hw/m68k/*.h
> 
> All .c should include qemu/osdep.h first.  The script performs three
> related cleanups:
> 
> * Ensure .c files include qemu/osdep.h first.
> * Including it in a .h is redundant, since the .c  already includes
>   it.  Drop such inclusions.
> * Likewise, including headers qemu/osdep.h includes is redundant.
>   Drop these, too.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  include/hw/audio/asc.h      | 1 -
>  include/hw/m68k/q800-glue.h | 1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

> 
> diff --git a/include/hw/audio/asc.h b/include/hw/audio/asc.h
> index 4741f92c461..04fac270b6a 100644
> --- a/include/hw/audio/asc.h
> +++ b/include/hw/audio/asc.h
> @@ -13,7 +13,6 @@
>  #ifndef HW_AUDIO_ASC_H
>  #define HW_AUDIO_ASC_H
>  
> -#include "qemu/osdep.h"
>  #include "hw/sysbus.h"
>  #include "audio/audio.h"
>  
> diff --git a/include/hw/m68k/q800-glue.h b/include/hw/m68k/q800-glue.h
> index ceb916d16c1..04fac25f6c2 100644
> --- a/include/hw/m68k/q800-glue.h
> +++ b/include/hw/m68k/q800-glue.h
> @@ -23,7 +23,6 @@
>  #ifndef HW_Q800_GLUE_H
>  #define HW_Q800_GLUE_H
>  
> -#include "qemu/osdep.h"
>  #include "hw/sysbus.h"
>  
>  #define TYPE_GLUE "q800-glue"
> -- 
> 2.34.1
> 
>