qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] accel/kvm: Turn DPRINTF macro use into tracepoints


From: Alex Bennée
Subject: Re: [PATCH v3] accel/kvm: Turn DPRINTF macro use into tracepoints
Date: Thu, 30 Nov 2023 17:11:15 +0000
User-agent: mu4e 1.11.25; emacs 29.1

Jai Arora <arorajai2798@gmail.com> writes:

> Patch removes DRPINTF macro and adds multiple tracepoints
> to capture different kvm events.

maybe add "We drop the DPRINTFs that don't add any additional
information than trace_kvm_run_exit already does."

Otherwise:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

p.s.

It is helpful to add a mini-changelog bellow the --- line so reviewers
can see what changes have already been made to the patch. The git
tooling will strip this log when the maintainer applies the patches.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro



reply via email to

[Prev in Thread] Current Thread [Next in Thread]