[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] semihosting: fix memleak at semihosting_arg_fallback
|
From: |
Alex Bennée |
|
Subject: |
Re: [PATCH v2] semihosting: fix memleak at semihosting_arg_fallback |
|
Date: |
Fri, 20 Oct 2023 13:55:42 +0100 |
|
User-agent: |
mu4e 1.11.22; emacs 29.1.50 |
Matheus Tavares Bernardino <quic_mathbern@quicinc.com> writes:
> We duplicate "cmd" as strtok may modify its argument, but we forgot
> to free it later. Furthermore, add_semihosting_arg doesn't take
> responsibility for this memory either (it strdup's the argument).
>
> Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Queued to semihosting/next, thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro