Re: [PATCH] tests/qtest/test-hmp: Improve the check for verbose mode

[Laurent Vivier]

Le 09/01/2023 à 11:13, Thomas Huth a écrit :
> Running the test-hmp with V=2 up to V=9 runs the test in verbose mode,
> but running for example with V=10 falls back to non-verbose mode ...
> Improve this oddity by properly treating the argument as a number.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qtest/test-hmp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c
> index f8b22abe4c..b4a920df89 100644
> --- a/tests/qtest/test-hmp.c
> +++ b/tests/qtest/test-hmp.c
> @@ -151,7 +151,7 @@ int main(int argc, char **argv)
>   {
>       char *v_env = getenv("V");
>   
> -    if (v_env && *v_env >= '2') {
> +    if (v_env && atoi(v_env) >= 2) {
>           verbose = true;
>       }
>   

Applied to my trivial-patches branch.

Thanks,
Laurent