[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Make -Waddress-of-pac
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] configure: Make -Waddress-of-packed-member warnings be errors |
Date: |
Thu, 14 Feb 2019 10:48:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 08/02/2019 14:33, Thomas Huth wrote:
> On 2019-02-08 14:21, Peter Maydell wrote:
>> We have now managed to eradicate all the places in the codebase
>> that triggered clang's -Waddress-of-packed-member warning. Remove
>> the compiler flag that exempted it from our usual -Werror policy.
>> This will prevent any new problematic code being added in future.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> configure | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index fbd0825488c..50ac5d90f2e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1881,7 +1881,6 @@ gcc_flags="-Wno-missing-include-dirs -Wempty-body
>> -Wnested-externs $gcc_flags"
>> gcc_flags="-Wendif-labels -Wno-shift-negative-value $gcc_flags"
>> gcc_flags="-Wno-initializer-overrides -Wexpansion-to-defined $gcc_flags"
>> gcc_flags="-Wno-string-plus-int $gcc_flags"
>> -gcc_flags="-Wno-error=address-of-packed-member $gcc_flags"
>> # Note that we do not add -Werror to gcc_flags here, because that would
>> # enable it for all configure tests. If a configure test failed due
>> # to -Werror this would just silently disable some features,
>
> Great!
>
> Reviewed-by: Thomas Huth <address@hidden>
>
Applied to my trivial-patches branch.
Thanks,
Laurent