Re: [Qemu-stable] [PATCH 59/97] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs

[Michael Roth]

Quoting Max Filippov (2019-04-01 16:19:59)
> Hi Michael,
> 
> On Mon, Apr 1, 2019 at 2:04 PM Michael Roth <address@hidden> wrote:
> > From: Max Filippov <address@hidden>
> >
> > Now that xtensa_count_regs does the right thing, remove manual
> > initialization of these fields from the affected configurations and let
> > xtensa_finalize_config initialize them. Add XTREG_END to terminate
> > register lists.
> >
> > Signed-off-by: Max Filippov <address@hidden>
> > (cherry picked from commit 7da9111e77b9cdb3a927dcd47642b7ffff9de636)
> > Signed-off-by: Michael Roth <address@hidden>
> 
> I'm curious why this change was picked for stable, it wasn't marked for it.
> I'm pretty sure it's not going to work without the corresponding change
> in the xtensa_count_regs, which is pretty big.

Looks like an earlier patch was tagged for stable:

  https://patchwork.kernel.org/patch/10666423/

Since patches are often referred to qemu-stable via actual email Cc: and
often don't get tagged in the commit I don't rely too much on the
"Cc: address@hidden" tags in the commit messages currently.

I should probably take note next time a tag is explicitly removed from the
final commit though, but the safest way to avoid this if a patch ends up
getting Cc'd to qemu-stable at some point is to reply to the patch on why
it should be kept out, since I'll usually see those.

I'll make sure to back the patch out, thanks for checking!

> 
> -- 
> Thanks.
> -- Max
>