Re: [qemu-s390x] [Qemu-devel] [PATCH v1 10/41] s390x/tcg: Implement VECTOR ELEMENT COMPARE *

[Richard Henderson]

On 4/11/19 12:08 AM, David Hildenbrand wrote:
> +                         es | logical ? 0 : MO_SIGN);

Incorrect operator precedence.  You need:

  es | (logical ? 0 : MO_SIGN)

or

  logical ? es : es | MO_SIGN

And perhaps cse this expression into a temporary
and not replicate it between the two reads.

Otherwise,
Reviewed-by: Richard Henderson <address@hidden>


r~