Re: [qemu-s390x] [PATCH RFC 1/2] tests/tcg: Allow targets to set the optimization level

[Alex Bennée]

David Hildenbrand <address@hidden> writes:

> We sometimes want basic optimizations, e.g. for constant propagation
> into inlined functions.
>
> Especially for inline asm with immediates;

I agree you need this, but...

<snip>
>  # Start with a blank slate, the build targets get to add stuff first
> -CFLAGS=
> +CFLAGS=-O0
>  QEMU_CFLAGS=
>  LDFLAGS=
>
> @@ -70,7 +70,7 @@ ifneq ($(TARGET_BASE_ARCH),$(TARGET_NAME))
>  endif
>
>  # Add the common build options
> -CFLAGS+=-Wall -O0 -g -fno-strict-aliasing
> +CFLAGS+=-Wall -g -fno-strict-aliasing


You don't need to do this - we already have EXTRA_CFLAGS which will
always be at the end of the compile invocation:

  # enable vectors and optimisation to vectorise for this test
  vglv: CFLAGS+=-march=z13 -m64
  vglv: EXTRA_CFLAGS+=-O2


>  ifeq ($(BUILD_STATIC),y)
>  LDFLAGS+=-static
>  endif


--
Alex Bennée