Re: [qemu-s390x] [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model

[Farhan Ali]

On 02/13/2019 11:26 AM, Cornelia Huck wrote:
> On Wed, 13 Feb 2019 10:54:23 -0500
> Farhan Ali <address@hidden> wrote:
>
> > I noticed the qemu-iotests 200 was failing due to the commit
> > "703fef6fcf3 : s390x/pci: Warn when adding PCI devices without the
> > 'zpci' feature".
> >
> > This patch fixes the failure :).
>
> Huh. So it was testing without pci before and now with and it's also
> working? Awesome :)

It was testing with pci, but the reason it fails was because qemu was 
spitting out the warning due to commit 703fef6fcf3. Now David's commit 
adds the zpci to qemu cpu model and qemu doesn't give out a warning message.
> > Thanks
> > Farhan
> >
> > On 02/12/2019 06:23 AM, David Hildenbrand wrote:
> > > As we now always have PCI support, let's add it to the "qemu" CPU model,
> > > taking care of backwards compatibility.
> > >
> > > Signed-off-by: David Hildenbrand<address@hidden>
> > > ---
> > >
> > > v1 -> v2:
> > > - Use correct model identifiction of the z12 we emulate
> > >
> > >    hw/s390x/s390-virtio-ccw.c  | 3 +++
> > >    target/s390x/gen-features.c | 8 ++++++--
> > >    2 files changed, 9 insertions(+), 2 deletions(-)