[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PATCH v3 8/9] target/s390x: Skip wout, cout helpers if op
From: |
Richard Henderson |
Subject: |
[qemu-s390x] [PATCH v3 8/9] target/s390x: Skip wout, cout helpers if op helper does not return |
Date: |
Wed, 3 Oct 2018 14:39:30 -0500 |
When op raises an exception, it may not have initialized the output
temps that would be written back by wout or cout.
Cc: address@hidden
Signed-off-by: Richard Henderson <address@hidden>
---
target/s390x/translate.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index 7363aabf3a..7fad3ad8e9 100644
--- a/target/s390x/translate.c
+++ b/target/s390x/translate.c
@@ -6164,11 +6164,13 @@ static DisasJumpType translate_one(CPUS390XState *env,
DisasContext *s)
if (insn->help_op) {
ret = insn->help_op(s, &o);
}
- if (insn->help_wout) {
- insn->help_wout(s, &f, &o);
- }
- if (insn->help_cout) {
- insn->help_cout(s, &o);
+ if (ret != DISAS_NORETURN) {
+ if (insn->help_wout) {
+ insn->help_wout(s, &f, &o);
+ }
+ if (insn->help_cout) {
+ insn->help_cout(s, &o);
+ }
}
/* Free any temporaries created by the helpers. */
--
2.17.1
- [qemu-s390x] [PATCH v3 8/9] target/s390x: Skip wout, cout helpers if op helper does not return,
Richard Henderson <=