[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v10 09/18] target/riscv/kvm: add 'rva22u64' flag as unavailable
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v10 09/18] target/riscv/kvm: add 'rva22u64' flag as unavailable |
Date: |
Fri, 3 Nov 2023 10:46:20 -0300 |
KVM does not have the means to support enabling the rva22u64 profile.
The main reasons are:
- we're missing support for some mandatory rva22u64 extensions in the
KVM module;
- we can't make promises about enabling a profile since it all depends
on host support in the end.
We'll revisit this decision in the future if needed. For now mark the
'rva22u64' profile as unavailable when running a KVM CPU:
$ qemu-system-riscv64 -machine virt,accel=kvm -cpu rv64,rva22u64=true
qemu-system-riscv64: can't apply global rv64-riscv-cpu.rva22u64=true:
'rva22u64' is not available with KVM
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
---
target/riscv/kvm/kvm-cpu.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c
index 78fa1fa162..9c6ff774b5 100644
--- a/target/riscv/kvm/kvm-cpu.c
+++ b/target/riscv/kvm/kvm-cpu.c
@@ -398,7 +398,7 @@ static void cpu_set_cfg_unavailable(Object *obj, Visitor *v,
}
if (value) {
- error_setg(errp, "extension %s is not available with KVM",
+ error_setg(errp, "'%s' is not available with KVM",
propname);
}
}
@@ -479,6 +479,11 @@ static void kvm_riscv_add_cpu_user_properties(Object
*cpu_obj)
riscv_cpu_add_kvm_unavail_prop_array(cpu_obj, riscv_cpu_extensions);
riscv_cpu_add_kvm_unavail_prop_array(cpu_obj, riscv_cpu_vendor_exts);
riscv_cpu_add_kvm_unavail_prop_array(cpu_obj, riscv_cpu_experimental_exts);
+
+ /* We don't have the needed KVM support for profiles */
+ for (i = 0; riscv_profiles[i] != NULL; i++) {
+ riscv_cpu_add_kvm_unavail_prop(cpu_obj, riscv_profiles[i]->name);
+ }
}
static int kvm_riscv_get_regs_core(CPUState *cs)
--
2.41.0
- [PATCH v10 01/18] target/riscv: create TYPE_RISCV_VENDOR_CPU, (continued)
- [PATCH v10 01/18] target/riscv: create TYPE_RISCV_VENDOR_CPU, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 02/18] target/riscv/tcg: do not use "!generic" CPU checks, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 03/18] target/riscv/tcg: update priv_ver on user_set extensions, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 04/18] target/riscv: add rv64i CPU, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 05/18] target/riscv: add zicbop extension flag, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 06/18] target/riscv/tcg: add 'zic64b' support, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 08/18] target/riscv: add rva22u64 profile definition, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 09/18] target/riscv/kvm: add 'rva22u64' flag as unavailable,
Daniel Henrique Barboza <=
- [PATCH v10 10/18] target/riscv/tcg: add user flag for profile support, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 07/18] riscv-qmp-cmds.c: expose named features in cpu_model_expansion, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 11/18] target/riscv/tcg: add MISA user options hash, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 12/18] target/riscv/tcg: add riscv_cpu_write_misa_bit(), Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 13/18] target/riscv/tcg: handle profile MISA bits, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 14/18] target/riscv/tcg: add hash table insert helpers, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 15/18] target/riscv/tcg: honor user choice for G MISA bits, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 17/18] riscv-qmp-cmds.c: add profile flags in cpu-model-expansion, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 18/18] target/riscv: add 'rva22u64' CPU, Daniel Henrique Barboza, 2023/11/03
- [PATCH v10 16/18] target/riscv/tcg: validate profiles during finalize, Daniel Henrique Barboza, 2023/11/03