[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/riscv/cpu.c: Fix elen check
From: |
Alistair Francis |
Subject: |
Re: [PATCH] target/riscv/cpu.c: Fix elen check |
Date: |
Wed, 28 Dec 2022 15:46:02 +1000 |
On Fri, Dec 16, 2022 at 1:10 AM Elta <503386372@qq.com> wrote:
>
> Should be cpu->cfg.elen in range [8, 64].
>
> Signed-off-by: Dongxue Zhang <elta.era@gmail.com>
Thanks for the patch!
I'm seeing weird formatting issues though, it looks like the encoding
is incorrect.
Did you use `git send-email` to send the patch? If not can you try
sending it again following the instructions here
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches
Alistair
> ---
> target/riscv/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> index d14e95c9dc..1e8032c969 100644
> --- a/target/riscv/cpu.c
> +++ b/target/riscv/cpu.c
> @@ -870,7 +870,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error
> **errp)
> "Vector extension ELEN must be power of 2");
> return;
> }
> - if (cpu->cfg.elen > 64 || cpu->cfg.vlen < 8) {
> + if (cpu->cfg.elen > 64 || cpu->cfg.elen < 8) {
> error_setg(errp,
> "Vector extension implementation only supports ELEN "
> "in the range [8, 64]");
> --
> 2.17.1
>