[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] roms/opensbi: Remove ELF images
From: |
Alistair Francis |
Subject: |
Re: [PATCH v2 3/3] roms/opensbi: Remove ELF images |
Date: |
Wed, 19 Jan 2022 08:33:07 +1000 |
On Tue, Jan 18, 2022 at 9:22 PM Anup Patel <apatel@ventanamicro.com> wrote:
>
> Now that all RISC-V machines can use OpenSBI BIN images, we remove
> OpenSBI ELF images and also exclude these images from BIOS build.
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
In future it's best to not send a large binary blob:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#avoid-posting-large-binary-blob
Alistair
> ---
> pc-bios/meson.build | 2 --
> pc-bios/opensbi-riscv32-generic-fw_dynamic.elf | Bin 838904 -> 0 bytes
> pc-bios/opensbi-riscv64-generic-fw_dynamic.elf | Bin 934696 -> 0 bytes
> roms/Makefile | 2 --
> 4 files changed, 4 deletions(-)
> delete mode 100644 pc-bios/opensbi-riscv32-generic-fw_dynamic.elf
> delete mode 100644 pc-bios/opensbi-riscv64-generic-fw_dynamic.elf
>
> diff --git a/pc-bios/meson.build b/pc-bios/meson.build
> index 1812a4084f..4ac7a5509b 100644
> --- a/pc-bios/meson.build
> +++ b/pc-bios/meson.build
> @@ -80,8 +80,6 @@ blobs = files(
> 'hppa-firmware.img',
> 'opensbi-riscv32-generic-fw_dynamic.bin',
> 'opensbi-riscv64-generic-fw_dynamic.bin',
> - 'opensbi-riscv32-generic-fw_dynamic.elf',
> - 'opensbi-riscv64-generic-fw_dynamic.elf',
> 'npcm7xx_bootrom.bin',
> )
>