[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v5 03/12] target/riscv: Implement function kvm_arch_init_
From: |
Alistair Francis |
Subject: |
Re: [PATCH RFC v5 03/12] target/riscv: Implement function kvm_arch_init_vcpu |
Date: |
Thu, 15 Apr 2021 08:32:09 +1000 |
On Mon, Apr 12, 2021 at 4:53 PM Yifei Jiang <jiangyifei@huawei.com> wrote:
>
> Get isa info from kvm while kvm init.
>
> Signed-off-by: Yifei Jiang <jiangyifei@huawei.com>
> Signed-off-by: Yipeng Yin <yinyipeng1@huawei.com>
> ---
> target/riscv/kvm.c | 27 ++++++++++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/target/riscv/kvm.c b/target/riscv/kvm.c
> index 687dd4b621..0d924be33f 100644
> --- a/target/riscv/kvm.c
> +++ b/target/riscv/kvm.c
> @@ -38,6 +38,18 @@
> #include "qemu/log.h"
> #include "hw/loader.h"
>
> +static __u64 kvm_riscv_reg_id(CPURISCVState *env, __u64 type, __u64 idx)
> +{
> + __u64 id = KVM_REG_RISCV | type | idx;
Can you use uint64_t instead of __u64?
Once that is fixed:
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> +
> + if (riscv_cpu_is_32bit(env)) {
> + id |= KVM_REG_SIZE_U32;
> + } else {
> + id |= KVM_REG_SIZE_U64;
> + }
> + return id;
> +}
> +
> const KVMCapabilityInfo kvm_arch_required_capabilities[] = {
> KVM_CAP_LAST_INFO
> };
> @@ -79,7 +91,20 @@ void kvm_arch_init_irq_routing(KVMState *s)
>
> int kvm_arch_init_vcpu(CPUState *cs)
> {
> - return 0;
> + int ret = 0;
> + target_ulong isa;
> + RISCVCPU *cpu = RISCV_CPU(cs);
> + CPURISCVState *env = &cpu->env;
> + __u64 id;
> +
> + id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG,
> KVM_REG_RISCV_CONFIG_REG(isa));
> + ret = kvm_get_one_reg(cs, id, &isa);
> + if (ret) {
> + return ret;
> + }
> + env->misa = isa | RVXLEN;
> +
> + return ret;
> }
>
> int kvm_arch_msi_data_to_gsi(uint32_t data)
> --
> 2.19.1
>
>
- [PATCH RFC v5 00/12] Add riscv kvm accel support, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 01/12] linux-header: Update linux/kvm.h, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 06/12] target/riscv: Support start kernel directly by KVM, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 03/12] target/riscv: Implement function kvm_arch_init_vcpu, Yifei Jiang, 2021/04/12
- Re: [PATCH RFC v5 03/12] target/riscv: Implement function kvm_arch_init_vcpu,
Alistair Francis <=
- [PATCH RFC v5 02/12] target/riscv: Add target/riscv/kvm.c to place the public kvm interface, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 05/12] target/riscv: Implement kvm_arch_put_registers, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 04/12] target/riscv: Implement kvm_arch_get_registers, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 07/12] hw/riscv: PLIC update external interrupt by KVM when kvm enabled, Yifei Jiang, 2021/04/12
- [PATCH RFC v5 11/12] target/riscv: Implement virtual time adjusting with vm state changing, Yifei Jiang, 2021/04/12