[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/3] target/riscv: Tell gdbstub the correct number of CSRs
From: |
Bin Meng |
Subject: |
Re: [PATCH v3 1/3] target/riscv: Tell gdbstub the correct number of CSRs |
Date: |
Tue, 8 Oct 2019 17:53:37 +0800 |
On Tue, Oct 8, 2019 at 8:15 AM Jonathan Behrens <address@hidden> wrote:
>
> If the number of registers reported to the gdbstub code does not match the
> number in the associated XML file, then the register numbers used by the stub
> may get out of sync with a remote GDB instance.
I am not sure how to trigger the out of sync issue. Do you know how?
>
> Signed-off-by: Jonathan Behrens <address@hidden>
> ---
> target/riscv/gdbstub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/riscv/gdbstub.c b/target/riscv/gdbstub.c
> index ded140e8d8..cb5bfd3d50 100644
> --- a/target/riscv/gdbstub.c
> +++ b/target/riscv/gdbstub.c
> @@ -384,7 +384,7 @@ void riscv_cpu_register_gdb_regs_for_features(CPUState
> *cs)
> }
>
> gdb_register_coprocessor(cs, riscv_gdb_get_csr, riscv_gdb_set_csr,
> - 4096, "riscv-32bit-csr.xml", 0);
> + 240, "riscv-32bit-csr.xml", 0);
> #elif defined(TARGET_RISCV64)
> if (env->misa & RVF) {
> gdb_register_coprocessor(cs, riscv_gdb_get_fpu, riscv_gdb_set_fpu,
> @@ -392,6 +392,6 @@ void riscv_cpu_register_gdb_regs_for_features(CPUState
> *cs)
> }
>
> gdb_register_coprocessor(cs, riscv_gdb_get_csr, riscv_gdb_set_csr,
> - 4096, "riscv-64bit-csr.xml", 0);
> + 240, "riscv-64bit-csr.xml", 0);
> #endif
> }
The change looks good to me.
Reviewed-by: Bin Meng <address@hidden>