[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-riscv] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-riscv] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64} |
Date: |
Thu, 8 Aug 2019 16:44:38 +0200 |
On Wed, 7 Aug 2019 08:30:04 +0000
<address@hidden> wrote:
> Temporarily no-op size_memop was introduced to aid the conversion of
> memory_region_dispatch_{read|write} operand "unsigned size" into
> "MemOp op".
>
> Now size_memop is implemented, again hard coded size but with
"Now that size_memop has been implemented properly, again hard code the
size but with..."
> MO_{8|16|32|64}. This is more expressive and avoid size_memop calls.
s/avoid/avoids/
>
> Signed-off-by: Tony Nguyen <address@hidden>
> ---
> hw/s390x/s390-pci-inst.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-riscv] [Qemu-devel] [PATCH v6 21/26] cputlb: Replace size and endian operands for MemOp, (continued)
- [Qemu-riscv] [Qemu-devel] [PATCH v6 21/26] cputlb: Replace size and endian operands for MemOp, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 24/26] cputlb: Byte swap memory transaction attribute, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 13/26] target/mips: Hard code size with MO_{8|16|32|64}, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 14/26] exec: Hard code size with MO_{8|16|32|64}, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 25/26] target/sparc: Add TLB entry with attributes, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 12/26] hw/s390x: Hard code size with MO_{8|16|32|64}, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 03/26] memory: Introduce size_memop, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 05/26] hw/s390x: Access MemoryRegion with MemOp, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 17/26] exec: Replace device_endian with MemOp, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 22/26] memory: Single byte swap along the I/O path, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 23/26] cpu: TLB_FLAGS_MASK bit to force memory slow path, tony.nguyen, 2019/08/07
- [Qemu-riscv] [Qemu-devel] [PATCH v6 20/26] memory: Access MemoryRegion with endianness, tony.nguyen, 2019/08/07